Fix HTML style for ThemeEntry #15609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please show a before-after for the HTML, pointing out where it's bad. |
|
@Piedone added some screenshots in the description. |
|
Thanks! |
Piedone
approved these changes
Mar 28, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have bad HTML where we wrap list tag with a paragraph tag.
Also, fix placement to allow placing multiple buttons inline.
Due to the wrapped paragraph tag, we get this large white-space.
Also, if you try to inject a new button, it does not nicely fit inline
After the change, the buttons can be placed inline and the white-space is gone.