Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure.Search.Documents 11.6.0-beta.3 #15635

Closed
wants to merge 1 commit into from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Apr 1, 2024

@hishamco hishamco requested a review from agriffard as a code owner April 1, 2024 03:04
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should update to beta versions, unless they fix a bug that's important for us. NuGet analyzers also recommend not depending on non-release versions from a release package (that OC is).

@MikeAlhayek
Copy link
Member

I don't think we should update to beta versions, unless they fix a bug that's important for us. NuGet analyzers also recommend not depending on non-release versions from a release package (that OC is).

Agreed

@hishamco
Copy link
Member Author

hishamco commented Apr 1, 2024

No problem we will wait for next stable release

@MikeAlhayek MikeAlhayek closed this Apr 1, 2024
@Piedone
Copy link
Member

Piedone commented Apr 1, 2024

Also, I'm just stating the obvious, but please test these changes too. Even patch versions can bring breaking changes even if they shouldn't (we've seen this with .NET too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants