Add target attribute to Menu #15636
Merged
Add target attribute to Menu #15636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MikeAlhayek ，It's ready for review. |
MikeAlhayek
requested changes
Apr 1, 2024
src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/HtmlMenuItemPart.Edit.cshtml
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/LinkMenuItemPart.Edit.cshtml
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/MenuItemLink-HtmlMenuItem.cshtml
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/MenuItemLink.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheAgencyTheme/Views/MenuItemLink-HtmlMenuItem.liquid
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheAgencyTheme/Views/MenuItemLink-LinkMenuItem.liquid
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheBlogTheme/Views/MenuItemLink-HtmlMenuItem.liquid
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheBlogTheme/Views/MenuItemLink-LinkMenuItem.liquid
Outdated
Show resolved
Hide resolved
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
Hi @MikeAlhayek anything else to add? 😳 |
MikeAlhayek
requested changes
Jun 5, 2024
src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/HtmlMenuItemPart.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/LinkMenuItemPart.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Navigation/Views/NavigationItemLink.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Menu/Views/MenuItemLink.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Navigation.Core/NavigationItemBuilder.cs
Outdated
Show resolved
Hide resolved
…AdminNode.Fields.TreeEdit.cshtml Co-authored-by: Mike Alhayek <[email protected]>
…t.Edit.cshtml Co-authored-by: Mike Alhayek <[email protected]>
…der.cs Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
hishamco
requested changes
Jun 6, 2024
src/OrchardCore.Modules/OrchardCore.Menu/Views/MenuItemLink-LinkMenuItem.cshtml
Outdated
Show resolved
Hide resolved
MikeAlhayek
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #15541
This PR allows the user to specify the
targetproperty on both theMenusand theAdminMenusMenus
AdminMenus