-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions to register conditions in the Rules module #15645
Conversation
It's a binary-breaking change |
@hishamco |
I know what you mean, but while you changed the assembly it was considered a binary breaking change, anyhow while we accept the breaking changes in minor releases it's not a problem Again can we prevent breaking changes in minor releases coz sometimes accept and sometimes not :) |
@hishamco the only thing that would break is moving the rules to a different project because YesSQL stores the assembly name in the database when it is stored. So I am moving the models back to make sure Yessql won't have serialization problem. |
Here is a summary of the changes:
OrchardCore.Rules.Core
project.AddRule<>
extensions in the Core projectOrchardCore.Rules
project by using the new extensions.