Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FrozenDictionaries in ShapeTables #15651

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Use FrozenDictionaries in ShapeTables #15651

merged 8 commits into from
Apr 4, 2024

Conversation

sebastienros
Copy link
Member

Built once and used for lookups for each rendered shape.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

# Conflicts:
#	src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/FeatureShapeDescriptor.cs
@sebastienros
Copy link
Member Author

Snap, the build fails because now I need to also update some benchmarks nobody is using ... ;)

@sebastienros sebastienros merged commit a248c92 into main Apr 4, 2024
5 checks passed
@sebastienros sebastienros deleted the sebros/descriptors branch April 4, 2024 16:13
sarahelsaig added a commit to Lombiq/Helpful-Libraries that referenced this pull request Jul 28, 2024
to match DefaultShapeTableManager where this change was made in PR OrchardCMS/OrchardCore#15651.
sarahelsaig added a commit to Lombiq/Open-Source-Orchard-Core-Extensions that referenced this pull request Jul 28, 2024
to match DefaultShapeTableManager where this change was made in PR OrchardCMS/OrchardCore#15651.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants