Monaco 0.47 #15666
Monaco 0.47 #15666
Conversation
|
Did you test it with the built-in Monaco-using editors? |
Yes, tested with Text Field, Html Body Part and Templates (intellisense on Liquid filters). |
There was a problem hiding this comment.
I get this under the Templates editor:
2024-04-06_13h00_37.mp4
There was a problem hiding this comment.
I can't reproduce this behaviour.
If someone else can confirm, please do.
|
@agriffard is this something ready to merge? |
|
No, see above. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This could be closed while the bot handle updating the packages, right? |
|
No, it only handles NuGet updates, not NPM ones, and even for those this is special. |
|
Oops, I just notice that :) but AFAIK there's a both for such thing |
|
In principle yes but we don't use it, see #16318. |
|
What about such PRs #16297? I think there's a bot for them, I'm not sure if we still need it |
|
PRs like that are now disabled. Please check out the issue I linked. |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
|
Todo: Update to https://www.npmjs.com/package/monaco-editor/v/0.51.0 and retest. |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
https://www.npmjs.com/package/monaco-editor/v/0.47.0
https://github.com/microsoft/monaco-editor/releases/tag/v0.47.0