Add missing string comparison type to equals comparisons #15675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
requested review from
sfmskywalker,
deanmarcussen,
kevinchalet and
hishamco
as code owners
* Use System.StringComparison.Ordinal by default * Fix minor other issues or disable with pragma * Configure inspection level and allow list in Directory.Build.props
lahma
commented
Apr 6, 2024
| @@ -55,7 +55,7 @@ public void OnAuthorization(AuthorizationFilterContext context) | |||
| } | |||
|
|
|||
| var effectiveRequestSizePolicy = context.FindEffectivePolicy<IRequestSizePolicy>(); | |||
| if (effectiveRequestSizePolicy == null || effectiveRequestSizePolicy == this) | |||
There was a problem hiding this comment.
This equality cannot be true currently as this is not IRequestSizePolicy, seemed weird and caused analysis warning (as error)
|
@lahma I use to used |
|
I've added explicit using statements for |
sebastienros
approved these changes
Apr 8, 2024
MikeAlhayek
approved these changes
Apr 8, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<AnalysisLevel>latest-Recommended</AnalysisLevel>is a good starting point as it's basically industry best practices and items can be skipped when needed with#pragmawith a good reason.System.StringComparison.Ordinalby default#pragmaDirectory.Build.propshttps://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1309
Now can make separate PRs removing analysis allow list items and making things stricter after this.