Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redirect to index after settings update #15679

Conversation

M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented Apr 7, 2024

Fixes #15678

The reason of the issue is that updating database and cache may be performed little later the page is fetched on redirection after postback. The se old values may be shown to the user after saving the settings.

It seems that we don't need to redirect after saving because the data maybe actual and up-to-date with straightforward page life cycle without redirect.

@MikeAlhayek MikeAlhayek changed the title Issue 15678 bugfix: Remove redirect to index after update Remove redirect to index after settings update Apr 8, 2024
@MikeAlhayek MikeAlhayek merged commit df24a76 into OrchardCMS:main Apr 8, 2024
4 checks passed
@sebastienros
Copy link
Member

I believe we should keep a redirect after POSTs or refreshing the pages will do a re-submission.
The problem is probably a caching issue, and the Index action should re-load the information to display.

@MikeAlhayek
Copy link
Member

It would have to be caching. And I am thinking the second request is being handled by a different server. Because if this was handled by the same server, then the server would render the updated values.

@M-Lipin is your application running on a single web server instance or is your app being scaled to multiple instances? If it is multiple instances, is your environment setup to keep the client one a single web instance or does it assign the user to any available web service instance per request? In other words, is the ARR Affinity cookie is enabled?

@MikeAlhayek
Copy link
Member

@M-Lipin we are going to be undoing this PR. Can you please provide your input on the last comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings not reloaded on update
3 participants