-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the GraphQL user type reusable. #15691
Conversation
@hyzx86 your review please |
Hi @hishamco , When you review PR daily, do you manually check out contributors' repositories or do you have any tools to assist in this process? |
You can review by looking to the code, but sometimes you might need to try the change that made |
Yes, I need to try this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution
I merged your code in #15389 and it works just fine .
@MikeAlhayek anything to add here? |
@hishamco please merge if you approve. |
@hyzx86 for conducting reviews, see these yet unmerged tips I added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Just waiting for a last note then I will merge |
Enhances how the GraphQL
UserType
is build to make it more reliable when reused e.g. by #15389 TheUserType
does not depend on the schema builder to be populated any longer.Also fixes #15540