Jint 3.1.0

[agriffard]

https://github.com/sebastienros/jint/releases/tag/v3.1.0
https://www.nuget.org/packages/Jint/3.1.0

[Piedone]

Just to be sure: did you test it? :)

[Skrypt]

We have unit tests for the JavaScriptEngine. That one at least has some.

[hishamco]

Seems I will take the responsibility to add a functional test for almost the things in the framework :)

[Skrypt]

Or let's start asking functional tests or unit test with each PR's if they are missing. I think that's where we are at.

[Piedone]

I'll follow up on automated QA, because we absolutely need to do more on that front. However, for now, as a PR author everyone should make sure that their code doesn't break anything (I mean, I hope this is not controversial).

[agriffard]

There was an error during the build :

/home/runner/work/OrchardCore/OrchardCore/src/OrchardCore/OrchardCore.Configuration.KeyVault/OrchardCore.Configuration.KeyVault.csproj : error NU1902: Warning As Error: Package 'Azure.Identity' 1.10.4 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-wvxc-855f-jvrv [/home/runner/work/OrchardCore/OrchardCore/OrchardCore.sln]
  Failed to restore /home/runner/work/OrchardCore/OrchardCore/src/OrchardCore/OrchardCore.Configuration.KeyVault/OrchardCore.Configuration.KeyVault.csproj (in 95 ms).

[agriffard]

I merged main on this branch and it fixed it.

[lahma]

3.1 broke some advanced API signatures (preparing AST method's input and output types) so if the code still compiles, it should work as before (at least Jint's +60 000 tests still pass 😉).

[Piedone]

Thanks, @lahma! So, Antoine, did you test it?

[agriffard]

Thanks, @lahma! So, Antoine, did you test it?

I tested with TheBlogTheme recipe, add a layer with a Javascript condition.
The widget I add in the Footer zone, associated to this layer, is displayed if the condition is true and not displayed if the condition returned value is false.

[lahma]

Honestly folks, this release ain't that evil 😆 We incremented the version to warn about the possible compilation time breaking change. It's probably basically 3.0.2 -> 3.0.3 for you.