-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes about SectionDisplayDriver breaking changes #15792
Conversation
Related to #15488. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
I thought you have added obsolete attribute to avoid this unnecessary breaking change. Having obsolete attribute to the old methods will guide users on how to upgrade without breaking their code. |
From what I understood in yesterday meeting it was not necessary as it needs to be changed anyway. It will lead into needing to do the exact same change for everyone. |
We'll now, you'll get a compile time error and if you have a 3rd party package that depends on OC 1.x then your 3rd party library will throw an exception and prevents you from being able to upgrade until the 3rd party library offers an update too. But if you mark the old methods obsolete, then the code will at least work as before without crashing. you can upgrade your project with no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should introduce this breaking change. We should obsolete the old methods for now.
Co-authored-by: Mike Alhayek <[email protected]>
@Piedone