-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IDataMigrationManager.UpdateAsync(string) with IDataMigrationManager.UpdateAsync(IEnumerable<string>) #15909
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9997cd0
Move IDataMigrationManager.UpdateAsync(IEnumerable<string>) to extens…
hishamco abc78a6
Use Task.WhenAll()
hishamco 11cbcda
Use Task.WhenAll() in the interface default method
hishamco 8993f46
Address feedback
hishamco 2ce8c06
Obsolete UpdateAsync(string)
hishamco 0b7011f
Merge branch 'main' into hishamco/data-migrations
hishamco 3443c3c
Typo
Piedone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
src/OrchardCore/OrchardCore.Data.Abstractions/Extensions/DataMigrationManagerExtensions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Threading.Tasks; | ||
|
||
namespace OrchardCore.Data.Migration; | ||
|
||
/// <summary> | ||
/// Provides an extension methods for <see cref="IDataMigrationManager"/>. | ||
/// </summary> | ||
public static class DataMigrationManagerExtensions | ||
{ | ||
/// <summary> | ||
/// Updates the database to the latest version for the specified features. | ||
/// </summary> | ||
/// <param name="dataMigrationManager">The <see cref="IDataMigrationManager"/>.</param> | ||
/// <param name="features">The features to be updated.</param> | ||
public static async Task UpdateAsync(this IDataMigrationManager dataMigrationManager, IEnumerable<string> features) | ||
{ | ||
ArgumentNullException.ThrowIfNull(dataMigrationManager, nameof(dataMigrationManager)); | ||
ArgumentNullException.ThrowIfNull(features, nameof(features)); | ||
|
||
await Task.WhenAll(features.Select(dataMigrationManager.UpdateAsync)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail queries under everything but SQLite, don't use parallelization for SQL queries.