-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Migrations #15933
Cleanup Migrations #15933
Conversation
WalkthroughThis update primarily focuses on improving code readability and maintainability across various modules of OrchardCore. Changes include method renaming to adhere to async conventions, formatting constructor parameters for clarity, and minor adjustments in method calls and logging. Additionally, there are updates to data migration management, enhancing feature updates and method accessibility. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
src/OrchardCore/OrchardCore.Data.YesSql/Migration/DataMigrationManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Data/Migration/Records/DataMigrationRecord.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Data.YesSql/Migration/DataMigrationManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/OrchardCore/OrchardCore.Data.YesSql/Migration/DataMigrationManager.cs
Show resolved
Hide resolved
This pull request has merge conflicts. Please resolve those before requesting a review. |
As I am going through the migrations trying to solve a different problem. I clean up some of these services
Summary by CodeRabbit
Id
property.UpgradeAsync
method.