Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NLog.Web.AspNetCore 5.3.10 #15947

Merged
merged 1 commit into from
May 2, 2024
Merged

Update NLog.Web.AspNetCore 5.3.10 #15947

merged 1 commit into from
May 2, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented May 2, 2024 •
edited by coderabbitai bot
Loading

https://www.nuget.org/packages/NLog.Web.AspNetCore/5.3.10

Summary by CodeRabbit

  • Documentation
    • Updated the documentation for .NET libraries in Orchard Core to reflect the new version of NLog.Web.AspNetCore from 5.3.8 to 5.3.10.
  • Chores
    • Updated the NLog.Web.AspNetCore package version to 5.3.10 to enhance logging capabilities.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 2, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates primarily involve the upgrade of the NLog.Web.AspNetCore package from version 5.3.8 to 5.3.10. This change has been applied across two key files in the Orchard Core project, ensuring both the build dependencies and documentation reflect the new version of the logging library.

Changes

File Path Change Summary
src/OrchardCore.Build/.../Dependencies.props Updated NLog.Web.AspNetCore from 5.3.8 to 5.3.10.
src/docs/resources/.../README.md Documentation updated to reflect new version 5.3.10 of NLog.Web.AspNetCore.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c967b5d and 6f52d4a.
Files selected for processing (2)
  • src/OrchardCore.Build/Dependencies.props (1 hunks)
  • src/docs/resources/libraries/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/OrchardCore.Build/Dependencies.props
Additional Context Used
LanguageTool (102)
src/docs/resources/libraries/README.md (102)

Near line 8: Possible spelling mistake found.
Context: ...arp/AngleSharp/blob/devel/LICENSE) | | AWSSDK S3...

Near line 9: Possible spelling mistake found.
Context: ...s-sdk-net/blob/master/License.txt) | | [AWSSDK SecurityToken](https://github.com/aws/a...

Near line 9: Possible spelling mistake found.
Context: ...et/blob/master/License.txt) | | AWSSDK SecurityToken | ...

Near line 10: Possible spelling mistake found.
Context: ...s-sdk-net/blob/master/License.txt) | | [AWSSDK Extensions Setup](https://github.com/aw...

Near line 11: Add a space between sentences.
Context: .../master/License.txt) | | Azure Identity | Azure Active Directory tok...

Near line 13: Add a space between sentences.
Context: ...SE.txt) | | [Azure Configuration Secrets](https://github.com/Azure/azure-sdk-for-net/blob/Azure.Extensions.AspNetCore.Configuration.Secrets_1.3.1/...

Near line 13: Add a space between sentences.
Context: ...n provider implementation for Microsoft.Extensions.Configuration. | 1.3.1 |[MIT](https://g...

Near line 13: Add a space between sentences.
Context: ...implementation for Microsoft.Extensions.Configuration. | 1.3.1 |[MIT](https://github.com/Azur...

Near line 14: Add a space between sentences.
Context: ...er/LICENSE.txt) | | Azure Storage Blobs | Azure Storage Blobs ...

Near line 15: Possible spelling mistake found.
Context: ...CENSE.txt) | | [Azure Storage Blobs for DataProtection](https://github.com/Azure/azure-sdk-for...

Near line 15: Add a space between sentences.
Context: ... [Azure Storage Blobs for DataProtection](https://github.com/Azure/azure-sdk-for-net/blob/Azure.Extensions.AspNetCore.DataProtection.Blobs_1.3.2/s...

Near line 15: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...tCore.DataProtection.Blobs/README.md) | Allows storing ASP.NET Core DataProtection key...

Near line 15: Possible spelling mistake found.
Context: ...EADME.md) | Allows storing ASP.NET Core DataProtection keys in Azure Blob Storage. | 1.3.4 |[M...

Near line 16: Add a space between sentences.
Context: ...et/blob/master/LICENSE.txt) | | Castle.Core...

Near line 16: Possible spelling mistake found.
Context: ...github.com/castleproject/Core) | Castle DynamicProxy. | 5.1.1 |[Apache-2.0](https://github.c...

Near line 17: Possible spelling mistake found.
Context: ...eproject/Core/blob/master/LICENSE) | | [DocumentFormat.OpenXML](https://github.com/dotnet/Open...

Near line 17: Add a space between sentences.
Context: ...lob/master/LICENSE) | | [DocumentFormat.OpenXML](https://github.com/dotnet/Open-XML-SDK...

Near line 18: Add a space between sentences.
Context: ...n-XML-SDK/blob/main/LICENSE) | | Fluid.Core...

Near line 19: Possible spelling mistake found.
Context: ...(https://github.com/graphql/graphiql) | GraphiQL & GraphQL. | 7.8.0 | [MIT](https://gith...

Near line 20: Possible spelling mistake found.
Context: ...raphql/graphiql/blob/main/LICENSE) | | [HtmlSanitizer](https://github.com/mganss/HtmlSanitize...

Near line 21: Possible spelling mistake found.
Context: ...lSanitizer/blob/master/LICENSE.md) | | [ImageSharp](https://github.com/SixLabors/ImageShar...

Near line 21: Add a space between sentences.
Context: .../blob/master/LICENSE.md) | | ImageSharp | Middleware for ASP.NET-Core for imag...

Near line 21: Add a space between sentences.
Context: ...image manipulation. | 3.1.2 |Apache-2.0 | | [Irony.Core](h...

Near line 22: Add a space between sentences.
Context: ...arp.Web/blob/master/LICENSE) | | Irony.Core | A m...

Near line 23: Possible spelling mistake found.
Context: .../daxnet/irony/blob/master/LICENSE) | | Jint ...

Near line 23: Possible spelling mistake found.
Context: ...https://github.com/sebastienros/jint) | Javascript Interpreter for .NET. | 3.1.1 | [MIT](h...

Near line 24: Possible spelling mistake found.
Context: ...ebastienros/jint/blob/dev/LICENSE) | | [libphonenumber-csharp](https://github.com/twcclegg/libphonenu...

Near line 25: Possible spelling mistake found.
Context: ...p/blob/main/LICENSE) | | [Lorem.NET for netstandard](https://github.com/trichards57/Lorem.U...

Near line 25: Add a space between sentences.
Context: .../LICENSE) | | Lorem.NET for netstandard | A .NET library for all things ra...

Near line 25: Add a space between sentences.
Context: ...y for all things random! | 4.0.80 | MIT | | [Lucene.Net](https://github.com/ap...

Near line 26: Add a space between sentences.
Context: ...NET/blob/master/license.md) | | Lucene.Net |...

Near line 27: Possible spelling mistake found.
Context: ...lucenenet/blob/master/LICENSE.txt) | | MailKit ...

Near line 28: Possible spelling mistake found.
Context: ...dfast/MailKit/blob/master/LICENSE) | | Markdig |...

Near line 29: Possible spelling mistake found.
Context: ...o/markdig/blob/master/license.txt) | | [MessagePack](https://github.com/neuecc/MessagePack-...

Near line 29: Possible spelling mistake found.
Context: ...cc/MessagePack-CSharp) | Extremely Fast MessagePack Serializer for C# | 2.2.60 | [MIT](http...

Near line 29: Possible spelling mistake found.
Context: ...ck-CSharp) | Extremely Fast MessagePack Serializer for C# | 2.2.60 | [MIT](https://github....

Near line 30: Add a space between sentences.
Context: ...arp/blob/master/LICENSE) | | [Microsoft.Extensions.Http.Resilience](https://github.com/dot...

Near line 30: Add a space between sentences.
Context: ...ster/LICENSE) | | [Microsoft.Extensions.Http.Resilience](https://github.com/dotnet/e...

Near line 30: Add a space between sentences.
Context: ...LICENSE) | | [Microsoft.Extensions.Http.Resilience](https://github.com/dotnet/extensions/t...

Near line 30: Possible spelling mistake found.
Context: ... | Microsoft.Extensions.Http.Resilience | Resilience mechanisms for...

Near line 30: Possible spelling mistake found.
Context: ...Resilience) | Resilience mechanisms for HttpClient built on the Polly framework. | 8.4.0 |...

Near line 31: Add a space between sentences.
Context: ...sions/blob/main/LICENSE) | | [Microsoft.Identity.Web](https://github.com/AzureAD/microso...

Near line 31: Add a space between sentences.
Context: ...b/main/LICENSE) | | [Microsoft.Identity.Web](https://github.com/AzureAD/microsoft-i...

Near line 31: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...b.com/AzureAD/microsoft-identity-web) | Helps creating protected web apps and web API...

Near line 31: The verb ‘Helps’ is used with an infinitive.
Context: ...AzureAD/microsoft-identity-web) | Helps creating protected web apps and web APIs with Mi...

Near line 32: Add a space between sentences.
Context: ...web/blob/master/LICENSE) | | [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourc...

Near line 32: Add a space between sentences.
Context: ...ster/LICENSE) | | Microsoft.SourceLink.GitHub ...

Near line 33: Possible spelling mistake found.
Context: .../sourcelink/blob/main/License.txt) | | MimeKit ...

Near line 34: Possible spelling mistake found.
Context: ...dfast/MailKit/blob/master/LICENSE) | | [MiniProfiler](https://github.com/MiniProfiler/dotnet...

Near line 35: Possible spelling mistake found.
Context: ...iler/dotnet/blob/main/LICENSE.txt) | | NCrontab ...

Near line 37: Add a space between sentences.
Context: ...h-net/blob/main/LICENSE.txt) | | [Azure.Search.Documents](https://github.com/Azure/azu...

Near line 37: Add a space between sentences.
Context: ...lob/main/LICENSE.txt) | | [Azure.Search.Documents](https://github.com/Azure/azure-sdk-for...

Near line 37: Possible spelling mistake found.
Context: ...LICENSE.txt) | | [Azure.Search.Documents](https://github.com/Azure/azure-sdk-for-net/blob/Azure.Search.Documents_11.5.1/sdk/search/Azure.Search.Documents/README.md...

Near line 38: Add a space between sentences.
Context: ...web/blob/master/LICENSE) | | [Microsoft.Extensions.Azure](https://github.com/Azure/azure-s...

Near line 38: Add a space between sentences.
Context: ...ster/LICENSE) | | [Microsoft.Extensions.Azure](https://github.com/Azure/azure-sdk-for...

Near line 38: Possible spelling mistake found.
Context: ...LICENSE) | | [Microsoft.Extensions.Azure](https://github.com/Azure/azure-sdk-for-net/blob/Microsoft.Extensions.Azure_1.7.3/sdk/extensions/Microsoft.Extensions.Azure/R...

Near line 39: Possible spelling mistake found.
Context: ...-identity-web/blob/master/LICENSE) | | [Newtonsoft.Json](https://github.com/JamesNK/Newton...

Near line 39: Add a space between sentences.
Context: ...eb/blob/master/LICENSE) | | [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft....

Near line 39: Add a space between sentences.
Context: ...lob/master/LICENSE) | | Newtonsoft.Json | Json.NET is a popular high-performan...

Near line 39: Add a space between sentences.
Context: ... JSON framework for .NET | 13.0.3 | MIT | | [NJsonSchem...

Near line 40: Possible spelling mistake found.
Context: ...nsoft.Json/blob/master/LICENSE.md) | | [NJsonSchema](https://github.com/RicoSuter/NJsonSche...

Near line 41: Possible spelling mistake found.
Context: ...JsonSchema/blob/master/LICENSE.md) | | [NLog.Web.AspNetCore](https://github.com/NLog...

Near line 41: Add a space between sentences.
Context: ...chema/blob/master/LICENSE.md) | | [NLog.Web.AspNetCore](https://github.com/NLog/NLo...

Near line 41: Add a space between sentences.
Context: ...a/blob/master/LICENSE.md) | | [NLog.Web.AspNetCore](https://github.com/NLog/NLog.Web/tree/...

Near line 41: Add a space between sentences.
Context: ...ter/LICENSE.md) | | NLog.Web.AspNetCore | ...

Near line 41: Possible spelling mistake found.
Context: .../tree/master/src/NLog.Web.AspNetCore) | NLog integration for ASP.NET. | 5.3.10 | [BS...

Near line 41: Add a space between sentences.
Context: ...on for ASP.NET. | 5.3.10 | BSD-3-Clause | | [Noda Time](ht...

Near line 42: Possible spelling mistake found.
Context: ...NLog/NLog.Web/blob/master/LICENSE) | | [Noda Time](https://github.com/nodatime/nodat...

Near line 43: Possible spelling mistake found.
Context: .../nodatime/blob/master/LICENSE.txt) | | [OpenIddict](https://github.com/openiddict/openiddi...

Near line 44: Possible spelling mistake found.
Context: ...eniddict-core/blob/dev/LICENSE.md) | | PdfPig |...

Near line 45: Possible spelling mistake found.
Context: ...lyToad/PdfPig/blob/master/LICENSE) | | [Serilog.AspNetCore](https://github.com/serilog/...

Near line 45: Add a space between sentences.
Context: ...dfPig/blob/master/LICENSE) | | [Serilog.AspNetCore](https://github.com/serilog/serilog-asp...

Near line 45: Possible spelling mistake found.
Context: ...ithub.com/serilog/serilog-aspnetcore) | Serilog integration for ASP.NET Core. | 8.0.1 |...

Near line 46: Possible spelling mistake found.
Context: ...rilog-aspnetcore/blob/dev/LICENSE) | | [Shortcodes](https://github.com/sebastienros/shortc...

Near line 46: Possible spelling mistake found.
Context: ...//github.com/sebastienros/shortcodes) | Shortcodes processor for .NET. | 1.3.3 | [MIT](htt...

Near line 47: Possible spelling mistake found.
Context: ...enros/shortcodes/blob/dev/LICENSE) | | [StackExchange.Redis](https://github.com/StackExchange...

Near line 47: Add a space between sentences.
Context: ...es/blob/dev/LICENSE) | | [StackExchange.Redis](https://github.com/StackExchange/Stack...

Near line 47: Possible spelling mistake found.
Context: .../StackExchange.Redis) | General purpose redis client. | 2.7.33 | [MIT](https://github...

Near line 47: Add a space between sentences.
Context: ...al purpose redis client. | 2.7.33 | MIT | | [YesSql](https:/...

Near line 48: Possible spelling mistake found.
Context: ...kExchange.Redis/blob/main/LICENSE) | | [YesSql](https://github.com/sebastienros/yessql...

Near line 49: Possible spelling mistake found.
Context: ...astienros/yessql/blob/dev/LICENSE) | | ZString | ...

Near line 49: Possible spelling mistake found.
Context: ....com/Cysharp/ZString) | Zero Allocation StringBuilder for .NET Core and Unity. | 2.6.0 | [MIT...

Near line 63: Possible spelling mistake found.
Context: ...b/master/LICENSE-BSD-3-Clause.txt) | | [jquery-resizable-dom](https://github.com/RickStrahl/jquery-r...

Near line 64: Possible spelling mistake found.
Context: ...-resizable/blob/master/LICENSE.md) | | [js-cookie](https://github.com/js-cookie/js-cookie...

Near line 67: Possible spelling mistake found.
Context: ...onaco-editor/blob/main/LICENSE.md) | | [noUiSlider](https://github.com/leongersen/noUiSlid...

Near line 67: Possible spelling mistake found.
Context: ...s://github.com/leongersen/noUiSlider) | noUiSlider is a lightweight JavaScript range slide...

Near line 70: Possible spelling mistake found.
Context: ...JS/sortablejs/blob/master/LICENSE) | | Trumbowyg |...

Near line 71: Possible spelling mistake found.
Context: ...-D/Trumbowyg/blob/develop/LICENSE) | | [vue-multiselect](https://github.com/shentao/vue-multise...

Near line 71: Possible spelling mistake found.
Context: ...tao/vue-multiselect) | Universal select/multiselect/tagging component for Vue.js. | 2.1.6 |...

Near line 72: Add a space between sentences.
Context: ...ltiselect/blob/master/LICENSE) | | [Vue.Draggable](https://github.com/SortableJS/Vue.Drag...

Near line 72: Add a space between sentences.
Context: ...nt based on Sortable.js. | 2.24.3 | MIT | The below table...

Near line 74: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... | The below table lists the different Client side libraries: | Library | Usage | Version...

Near line 78: Possible spelling mistake found.
Context: ...| License | |--- | --- | --- | --- | | [EasyMDE](https://github.com/Ionaru/easy-markdow...

Near line 79: Possible spelling mistake found.
Context: ...rkdown-editor/blob/master/LICENSE) | | GraphiQL |...

Near line 80: Possible spelling mistake found.
Context: ...raphql/graphiql/blob/main/LICENSE) | | [GraphiQL explorer](https://github.com/onegraph/g...

Near line 80: Possible spelling mistake found.
Context: ...raphiql-explorer) | Explorer plugin for GraphiQL. | 0.6.3 | [MIT](https://github.com/One...

Near line 85: Possible spelling mistake found.
Context: ...le-Upload/blob/master/LICENSE.txt) | | jsPlumb | ...

Near line 85: Possible spelling mistake found.
Context: ...lumb/jsplumb) | Visual connectivity for webapps. | 2.15.6 | [MIT and GPLv2](https://git...

Near line 90: Possible spelling mistake found.
Context: ...ub.com/webpack/webpack) | A bundler for javascript and friends. | 5.75.0 | [MIT](https://g...

Near line 97: Possible spelling mistake found.
Context: ...| License | |--- | --- | --- | --- | | [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDot...

Near line 100: Possible spelling mistake found.
Context: ...ds for Orchard Core. | 0.4.5 | MIT | | Moq | The most...

Near line 104: Possible spelling mistake found.
Context: .../github.com/xunit/visualstudio.xunit) | VSTest runner for xUnit.net. | 2.8.0 | [MIT](h...

Additional comments not posted (1)
src/docs/resources/libraries/README.md (1)

41-41: Version update for NLog.Web.AspNetCore is correct and consistent with the document format.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hishamco
Copy link
Member Author

hishamco commented May 2, 2024

Just two packages have been updated

@Piedone Piedone merged commit c6b867e into main May 2, 2024
8 checks passed
@Piedone Piedone deleted the hishamco/nlog branch May 2, 2024 14:34
This was referenced Jun 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamco @Piedone