load flowpart and bagpart resources by name #15954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested changes
May 2, 2024
src/OrchardCore.Modules/OrchardCore.Widgets/ResourceManifest.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Widgets/ResourceManifest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
… flowpart-resources-by-name # Conflicts: # src/OrchardCore.Modules/OrchardCore.Flows/ResourceManifest.cs # src/OrchardCore.Modules/OrchardCore.Widgets/ResourceManifest.cs
@MikeAlhayek no it does'nt solve #15950. but this is required to have bagpart and flowpart on same content item. |
sure , i just think this is more clean. |
MikeAlhayek
requested changes
May 2, 2024
|
|
||
| namespace OrchardCore.Flows; | ||
|
|
||
| public class ResourceManagementOptionsConfiguration : IConfigureOptions<ResourceManagementOptions> |
There was a problem hiding this comment.
Well now you need to remove the extra indentation in the file.
|
|
||
| namespace OrchardCore.Widgets; | ||
|
|
||
| public class ResourceManagementOptionsConfiguration : IConfigureOptions<ResourceManagementOptions> |
There was a problem hiding this comment.
here too. every line have extra 4 spaces that should be removed
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid loading resources multiple times with content item that has bagpart and flowpart.