ListQueryObjectType should be filtered from the database #16037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyzx86
changed the title
hyzx86
changed the title
hishamco
requested changes
May 12, 2024
src/OrchardCore.Modules/OrchardCore.Lists/GraphQL/ListQueryObjectType.cs
Outdated
Show resolved
Hide resolved
…chardCore into fixListQueryObjectType
…ectType.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
|
I'm trying to check other content queries, but it doesn't look like there's any more optimization left |
hishamco
requested changes
May 12, 2024
src/OrchardCore.Modules/OrchardCore.Lists/GraphQL/ListQueryObjectType.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/GraphQL/ListQueryObjectType.cs
Outdated
Show resolved
Hide resolved
…ectType.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…ectType.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
approved these changes
May 12, 2024
|
Is there anything else before this can be merged, @hishamco? Please just merge if you're OK with it, to prevent any possible merge conflicts. |
|
I update to main then I will merge |
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue #15731,
Not a fix, just optimizing query performance