-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microsoft.IdentityModel.Protocols.OpenIdConnect 7.5.2 #16088
Conversation
OpenIddict is still on 7.5.1 and I haven't tested 7.5.2 yet. Bumping this dependency shouldn't be problematic as it references all the packages that are used by the MSFT OIDC handler and by OpenIddict, so we shouldn't have inconsistent versions, but please make sure the OpenID module is working fine before merging this PR 😃 |
@@ -51,7 +51,7 @@ | |||
See https://github.com/OrchardCMS/OrchardCore/pull/16057 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the entire comment: since this package covers both the dependencies used by the OIDC handler and by OpenIddict, we shouldn't end up in a case where there's an inconsistent version in the graph.
/cc @Piedone
This pull request has merge conflicts. Please resolve those before requesting a review. |
Can we merge this? |
Have you tested as Kévin asked for? |
I might prefer @kevinchalet to test it because he is our OpenID guru :) |
No problem, but in this case, I'd suggest refraining from bumping the I'll give IM 7.5.2 a try later today. |
No problem, it's on your plate :) |
Good, let's do that, then 👍🏻 |
https://www.nuget.org/packages/Microsoft.IdentityModel.Protocols.OpenIdConnect/7.5.2