Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.IdentityModel.Protocols.OpenIdConnect 7.5.2 #16088

Closed
wants to merge 5 commits into from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented May 17, 2024

@hishamco hishamco requested a review from kevinchalet May 17, 2024 22:30
@kevinchalet
Copy link
Member

OpenIddict is still on 7.5.1 and I haven't tested 7.5.2 yet. Bumping this dependency shouldn't be problematic as it references all the packages that are used by the MSFT OIDC handler and by OpenIddict, so we shouldn't have inconsistent versions, but please make sure the OpenID module is working fine before merging this PR 😃

@@ -51,7 +51,7 @@
See https://github.com/OrchardCMS/OrchardCore/pull/16057 for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the entire comment: since this package covers both the dependencies used by the OIDC handler and by OpenIddict, we shouldn't end up in a case where there's an inconsistent version in the graph.

/cc @Piedone

@hishamco hishamco requested a review from kevinchalet May 18, 2024 19:07
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@hishamco
Copy link
Member Author

Can we merge this?

@Piedone
Copy link
Member

Piedone commented May 22, 2024

Have you tested as Kévin asked for?

@hishamco
Copy link
Member Author

I might prefer @kevinchalet to test it because he is our OpenID guru :)

@kevinchalet
Copy link
Member

kevinchalet commented May 22, 2024

I might prefer @kevinchalet to test it because he is our OpenID guru :)

No problem, but in this case, I'd suggest refraining from bumping the Microsoft.IdentityModel.Protocols.OpenIdConnect package when a new version ships and simply waiting for OpenIddict to adopt it.

I'll give IM 7.5.2 a try later today.

@hishamco
Copy link
Member Author

I'd suggest refraining from bumping the Microsoft.IdentityModel.Protocols.OpenIdConnect package when a new version ships and simply waiting for OpenIddict to adopt it.

No problem, it's on your plate :)

@kevinchalet
Copy link
Member

Good, let's do that, then 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants