-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for adding basic content type filters #16111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai review
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThe recent updates to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
Outside diff range and nitpick comments (5)
src/docs/reference/core/Apis.GraphQL.Abstractions/README.md (5)
Line range hint
28-28
: Correct the possessive form for clarity.- Lets see how to wire a type in to the GraphQL schema; + Let's see how to wire a type into the GraphQL schema;
Line range hint
31-31
: Correct the possessive form for clarity.- First: Lets start with a simple C# part + First: Let's start with a simple C# part
Line range hint
61-61
: Simplify the language for better readability.- To do this, simple register it in a Startup class; + To do this, simply register it in a Startup class;
Line range hint
125-125
: Simplify the language for better readability.- all Input Types must inherit off of InputObjectGraphType. + all Input Types must inherit from InputObjectGraphType.
Line range hint
371-372
: Ensure consistency in list item markers.- - <https://graphql.org/learn/> - - <https://graphql-dotnet.github.io/docs/getting-started/introduction> + * <https://graphql.org/learn/> + * <https://graphql-dotnet.github.io/docs/getting-started/introduction>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the docs site locally and check it out in a browser before the next review: https://docs.orchardcore.net/en/latest/guides/contributing/contributing-documentation/#running-the-documentation-site-locally
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Piedone I may also learn to write in proper english if I keep updating the documentation :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hishamco please merge when you're happy with it.
Fixes #16112