Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Search Azure AI #16127

Merged
merged 3 commits into from
May 22, 2024
Merged

Improvements for Search Azure AI #16127

merged 3 commits into from
May 22, 2024

Conversation

MikeAlhayek
Copy link
Member

This PR improves few key area of the Azure AI Search module:

  1. Replaces primary constructors with standard constructors to be consistent with the rest of the code base.
  2. Improved the field mapping by adding a new listener to allow the user to override mappings "if needed".
  3. Centralized the logic for mapping fields into one place. The base logic is defined and is extensible.

@Piedone
Copy link
Member

Piedone commented May 22, 2024

I can do a static code review but not much more if that would help?

@MikeAlhayek
Copy link
Member Author

I am just doing some final testing and planning to merge it after. If you have suggestions, feel free to review.

@Piedone
Copy link
Member

Piedone commented May 22, 2024

Let's do that. I skimmed through the code, but can't comment.

@MikeAlhayek MikeAlhayek merged commit 58149c4 into main May 22, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/update-azure-search-ai branch May 22, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants