Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreliable unit test #16145

Merged
merged 5 commits into from
May 25, 2024
Merged

Fix unreliable unit test #16145

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17f82e9
Fix flaky test.
gvkries May 23, 2024
ad70147
Don't use a timeout.
gvkries May 24, 2024
4f71603
Merge branch 'main' into gvkries/unit-test-16018
gvkries May 24, 2024
748050f
React to code review.
gvkries May 25, 2024
65fb0af
Merge branch 'main' into gvkries/unit-test-16018
gvkries May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/OrchardCore.Tests/Apis/GraphQL/Queries/RecentBlogPostsQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ public async Task ShouldListBlogPostWhenCallingAQuery()
using var context = new BlogContext();
await context.InitializeAsync();

// The RecentBlogPosts query sorts the content items by CreatedUtc. Since
// the CreatedUtc property is managed automatically and cannot be set when
// adding a content item, adding this delay ensures that the second post is
// always newer.
// The delay was chosen to be higher than the clock resolution in most
// operating systems.
await Task.Delay(20);
gvkries marked this conversation as resolved.
Show resolved Hide resolved

var blogPostContentItemId = await context
.CreateContentItem("BlogPost", builder =>
{
Expand Down