Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid auto complete for OpenID scopes #16160

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Avoid auto complete for OpenID scopes #16160

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
db59baf
Avoid auto complete for OpenID scopes
hishamco May 26, 2024
15c3d0f
Merge branch 'main' into hishamco/openid-secrets
hishamco May 26, 2024
a39c3c7
Update src/OrchardCore.Modules/OrchardCore.OpenId/Views/OpenIdClientS…
hishamco May 27, 2024
65093af
Merge branch 'main' into hishamco/openid-secrets
hishamco May 29, 2024
3002645
Merge branch 'main' into hishamco/openid-secrets
hishamco May 30, 2024
478398f
Merge branch 'main' into hishamco/openid-secrets
hishamco Jun 16, 2024
e06ff5b
Use new-password instead
hishamco Jun 17, 2024
7df4597
Merge branch 'main' into hishamco/openid-secrets
hishamco Jun 17, 2024
7ddf843
Merge branch 'main' into hishamco/openid-secrets
hishamco Jun 17, 2024
67e1f50
Merge branch 'main' into hishamco/openid-secrets
hishamco Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.OpenId/Views/OpenIdClientSettings.Edit.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

<div class="mb-3" asp-validation-class-for="Scopes">
<label asp-for="Scopes" class="form-label">@T["Scopes"]</label>
<input asp-for="Scopes" class="form-control" />
<input asp-for="Scopes" class="form-control" autocomplete="new-password" />
<span asp-validation-for="Scopes"></span>
<span class="hint">@T["extra scopes except openid and profile"]</span>
</div>
Expand Down Expand Up @@ -144,7 +144,7 @@

<div class="mb-3 collapse" asp-validation-class-for="ClientSecret">
<label asp-for="ClientSecret" class="form-label">@T["Client Secret"]</label>
<input asp-for="ClientSecret" class="form-control" type="password" autocomplete="off" />
<input asp-for="ClientSecret" class="form-control" type="password" autocomplete="new-password" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a good solution 👍

<span asp-validation-for="ClientSecret"></span>
<span class="hint">@T["set client secret."]</span>
</div>
Expand Down