Use MinimalAPI for two-factor authentication code request #16174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
May 27, 2024
src/OrchardCore.Modules/OrchardCore.Users/TwoFactorAuthenticationStartup.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Controllers/TwoFactorAuthenticationController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/EmailAuthenticator/SendCode.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/EmailAuthenticator/SendCode.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/EmailAuthenticator/SendCode.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/EmailAuthenticator/SendCode.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/SmsAuthenticator/SendCode.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Endpoints/SmsAuthenticator/SendCode.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/TwoFactorAuthenticationStartup.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/TwoFactorAuthenticationStartup.cs
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
requested changes
May 27, 2024
src/OrchardCore.Modules/OrchardCore.Users/TwoFactorAuthenticationStartup.cs
Outdated
Show resolved
Hide resolved
@hishamco, MinimalAPIs are great when possible. One on their advantage over using controllers is that the reduce the overhead and they are executed early on in the request which add a slightly better performance and less resources. Any route that is acting like a REST request can/should be processed using a MinimalAPI. The two route in this PR are perfect candidates for using MinimalAPI. |
hishamco
approved these changes
May 27, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the 2FA code requests to use MinimalAPI