Use MinimalAPI for marking notifications as read #16175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
May 27, 2024
src/OrchardCore.Modules/OrchardCore.Notifications/Assets/js/notification-manager.js
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/Assets/js/notification-manager.js
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/Assets/js/notification-manager.js
Show resolved
Hide resolved
|
|
||
| public static class MarkAsReadEndpoints | ||
| { | ||
| public const string RouteName = "NotificationsMarkAsRead"; |
There was a problem hiding this comment.
I like the route how it was in other code base, because it will be used once
There was a problem hiding this comment.
Not sure what you are asking here. This is a route name. This is used to identify the route path later
src/OrchardCore.Modules/OrchardCore.Notifications/Endpoints/Management/MarkAsReadEndpoints.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/Endpoints/Management/MarkAsReadEndpoints.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/wwwroot/Scripts/notification-manager.js
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/wwwroot/Scripts/notification-manager.js
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Notifications/wwwroot/Scripts/notification-manager.js
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <[email protected]>
|
Please react to the remaining comments, then request for a review |
|
@hishamco everything that is worth taking was taken. Anything else? |
hishamco
approved these changes
May 27, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the route to mark notifications as read to use MinimalAPI.
Also, prevent sending a request to request to the server is one is already being sent. This will prevent sending multiple unnecessary request to the server.