Fixes building the GraphQL schema. #16184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyzx86 could you please check this out too? |
sebastienros
approved these changes
May 30, 2024
|
@gvkries anything else to add here or shall I merge? |
|
This PR is complete IMHO. |
|
I will update to master then merge |
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building the GraphQL schema that fails because the types must be registered as transient and are resolved multiple times.
Also this makes the schema building a little bit more efficient by mostly reusing already registered types.
Fixes #16182
/cc @MikeAlhayek @tropcicstefan