Add helpful ShellFeaturesManager extensions #16191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriffard
changed the title
|
Great, thanks a lot 🤗 This is such a needed thing... |
hishamco
requested changes
May 29, 2024
| return featuresToEnable; | ||
| } | ||
|
|
||
| public static async Task EnableFeaturesAsync(this IShellFeaturesManager shellFeaturesManager, params string[] featureIds) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(featureIds); |
There was a problem hiding this comment.
You need to check if the array is empty too
There was a problem hiding this comment.
It would do nothing when array is empty as this is handled by the underlying method.
There was a problem hiding this comment.
IMHO know need to call GetAvailableFeaturesAsync() if the featureIds is empty
There was a problem hiding this comment.
@hishamco done. anything else?
There was a problem hiding this comment.
The second time you can request a review rather than mention
hishamco
approved these changes
May 30, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following two extensions