Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful SiteService extension #16193

Merged
merged 14 commits into from
May 31, 2024
Merged

Add helpful SiteService extension #16193

merged 14 commits into from
May 31, 2024

Conversation

MikeAlhayek
Copy link
Member

Adding a helpful extension for ISiteService

public static async Task<T> GetSettingsAsync<T>(this ISiteService siteService) where T : new()
{
    return (await siteService.GetSiteSettingsAsync()).As<T>();
}

@Piedone Piedone mentioned this pull request May 29, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@hishamco
Copy link
Member

Please resolve the conflict

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek MikeAlhayek requested a review from hishamco May 30, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

hishamco
hishamco approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to the suggestion and comment before merge

src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Settings/SiteServiceExtensions.cs Show resolved Hide resolved
src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Settings/SiteServiceExtensions.cs Show resolved Hide resolved
src/docs/releases/2.0.0.md Outdated Show resolved Hide resolved
MikeAlhayek and others added 2 commits May 30, 2024 21:04
@MikeAlhayek @hishamco
Update 2.0.0.md
f137b05 
Co-authored-by: Hisham Bin Ateya <[email protected]>
@MikeAlhayek
comments
b8bdcd6
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) May 31, 2024 04:54
@MikeAlhayek MikeAlhayek merged commit 08ddb05 into main May 31, 2024
12 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/site-extensions branch May 31, 2024 04:59
This was referenced Jun 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyzx86 hyzx86 hyzx86 left review comments

@hishamco hishamco hishamco approved these changes

@Piedone Piedone Piedone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeAlhayek @hishamco @Piedone @hyzx86