Correct the order of module configurations

[MikeAlhayek]

Fix #14874

In the PR, we have introduced a central constants class that manages the order of module registrations. This improvement provides a comprehensive view of all registered modules, making it easier to adjust the order as needed. If someone needs to change the order of any module, they can see at a glance if other order numbers need to be adjusted accordingly.

[kevinchalet]

👍🏻

[Piedone]

I've swapped out the preview packages under Lombiq's Open-Source Orchard Core Extensions, this PR and has run its tests. Those passed, so this is a good sign.

[kevinchalet]

I don't see OrchardCore.Security in the list of changed files: it doesn't have an explicit order, but we should probably give it one while we're at it. Probably just before or after CORS (but after the reverse proxy module)

[MikeAlhayek]

I don't see OrchardCore.Security in the list of changed files: it doesn't have an explicit order, but we should probably give it one while we're at it. Probably just before or after CORS (but after the reverse proxy module)

@kevinchalet not a bad idea. I added that at the same order as CORS just to show that there is no significant difference in order between CORS and Reverse Proxy. I added a note as it must configured after the reverse proxy.

[kevinchalet]

@kevinchalet not a bad idea. I added that at the same order as CORS just to show that there is no significant difference in order between CORS and Reverse Proxy. I added a note as it must configured after the reverse proxy.

👍🏻

That said, I wonder if we shouldn't use unique values to make the order more explicit: I haven't tested, but since the ordering logic is just an .OrderBy(x => x.ConfigureOrder) on the list of IStartup services, I'd assume the actual order of modules having the same value actually depends on their position in the IServiceCollection instance (when using with LINQ to Objects, .OrderBy(...) performs a stable sort, but it depends on the ordering logic of the input collection).

[MikeAlhayek]

IMO, if there is a need to place one after another, then we should use unique values to guaranty the order. But, if there we don't care if CORS came before Security or the other way around, then I don't see the value of adding a unique value. In other words, if either Security or CORS were registered first, there should not be any issue.