Throws an exception if the datetime cannot be converted. #16288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Jun 11, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/DateTimeJsonConverter.cs
Show resolved
Hide resolved
| @@ -40,15 +49,26 @@ public void JsonNode_WhenParseCalled_ConvertShortTimeFormatToTimeField() | |||
| var dateField = jobject.SelectNode("DateFieldTest").ToObject<DateField>(); | |||
| var dateTimeField = jobject.SelectNode("DateTimeFieldTest").ToObject<DateTimeField>(); | |||
| var timezoneDateTimeFieldTest = jobject.SelectNode("TimezoneDateTimeFieldTest").ToObject<DateTimeField>(); | |||
| var nullDateTimeField = jobject.SelectNode("NullDateTimeFieldTest").ToObject<DateTimeField>(); | |||
There was a problem hiding this comment.
Please create another test instead
This was referenced Jul 1, 2024
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
…teTimeJsonConverter.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
gvkries
requested changes
Jul 25, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/DateTimeJsonConverter.cs
Show resolved
Hide resolved
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
added 2 commits
August 15, 2024 15:58
…hyzx86/OrchardCore into hyzx86/JsonDateTimeErrorHolding
gvkries
reviewed
Aug 15, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/DateTimeJsonConverter.cs
Show resolved
Hide resolved
|
Why did you change the exception to a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an exception if the datetime cannot be converted.
Patch for PR #16205
/cc @hishamco