Fix Twitter module breaking the Workflows editor (Lombiq Technologies: OCORE-189) #16350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User-facing content should continue to say "X".
sarahelsaig
commented
Jun 19, 2024
Comment on lines
-14
to
+21
| Name = "X Integration", | ||
| Name = "X (Twitter) Integration", | ||
| Category = "X", | ||
| Description = "Provides a TwitterClient and Workflow Activities to integrate with X" | ||
| )] | ||
|
|
||
| [assembly: Feature( | ||
| Id = TwitterConstants.Features.Signin, | ||
| Name = "Sign in with X", | ||
| Name = "Sign in with X (Twitter)", |
There was a problem hiding this comment.
I've added the (Twitter) here, because searching for the module is not very practical:
There was a problem hiding this comment.
I wanted to ask for this too, great!
Piedone
changed the title
Piedone
requested changes
Jun 20, 2024
There was a problem hiding this comment.
While this fixes the issue, there's the conflicting earlier PR, see #16349 (comment).
I don't use Twitter (nobody should use Twitter), so I'm fine with any solution that stops breaking our tests. |
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16349
I went ahead and made these changes, based on what made sense to me. Basically just reverted the shape names so there is no breaking change for shape overrides. Don't hesitate to chime in if it's the wrong direction.