Fix localization rule \Localization\[CultureName]\[ModuleId].po #16419
Conversation
|
@hishamco could you please review both PRs? |
|
Sure, in my list |
|
Thank you! |
|
Looks good. Can you add a unit test? Not with a web app, really a unit test. |
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
|
@hishamco Ready to review 😊 |
| @@ -195,6 +195,7 @@ node_modules/ | |||
|
|
|||
| wwwroot | |||
| **/Localization/**/*.po | |||
| !test/OrchardCore.Tests/Localization/**/*.po | |||
There was a problem hiding this comment.
You must do this, or you will lose the PO files. You can try it.
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
| [InlineData("zh-CN", "你好！")] | ||
| public async Task TestLocalizationRule(string culture, string expected) | ||
| { | ||
| var context = new SiteContext(); |
There was a problem hiding this comment.
This is a functional test, right?
There was a problem hiding this comment.
Sorry, I don't understand what you mean. I think this is the closest test to the actual operation.
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Localization/LocalizationManagerTests.cs
Outdated
Show resolved
Hide resolved
| <ItemGroup> | ||
| <None Update="Localization\*\OrchardCore.Tests.po"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
There was a problem hiding this comment.
No need, you can add them as embedded resources
There was a problem hiding this comment.
Why do we need to preserve the newest?
There was a problem hiding this comment.
Because the target rule needs to copy it to the output directory.
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Fixes #16153
unit test at :#16154