Handle invalid recipe files from breaking the harvester #16490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
Jul 26, 2024
src/OrchardCore/OrchardCore.Recipes.Core/Services/RecipeReader.cs
Outdated
Show resolved
Hide resolved
@Piedone I had multiple startup recipes in a module. The first one has a JSON issue, so none of them were listed in the add tenant. They all failed because one of them throw an exception. Ignoring and logging the faulty recipes would be better in this case since we would have more info on the faulty recipe and only the bad one is ignored not all of them. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
Piedone
approved these changes
Jul 26, 2024
hyzx86
pushed a commit
to hyzx86/OrchardCore
that referenced
this pull request
Jul 30, 2024
…6490) --------- Co-authored-by: Zoltán Lehóczky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.