Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot reload issue. #16624

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix hot reload issue. #16624

merged 1 commit into from
Aug 27, 2024

Conversation

shinexyt
Copy link
Contributor

Fixes #15946

Register the SharedViewCompilerProvider only in production mode, as it may cause hot reload to fail in development mode.

… it may cause hot reload to fail in development mode.
Copy link
Contributor

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

@shinexyt
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Contributor

@gvkries gvkries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shinexyt

@gvkries gvkries merged commit c173a8a into OrchardCMS:main Aug 27, 2024
11 checks passed
Copy link
Contributor

Congratulations on your first PR merge! 🎉 Thank you for your contribution! We're looking forward to welcoming other contributions of yours in the future. @all-contributors please add @shinexyt for code.

Copy link
Contributor

@github-actions[bot]

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @shinexyt! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload does not work for Razor page in OC 1.8.3.
2 participants