Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the configuration of JsonSerializerOptions #16634

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Aug 29, 2024

Updated:

Properly fix configuring DocumentJsonSerializerOptions

cc: @sarahelsaig

@MikeAlhayek MikeAlhayek changed the title Ma/fix merge Merge JsonSerializerOptions using reflection Aug 29, 2024
@hishamco
Copy link
Member

Why you are going with reflection? What about PERF?

This ensures that we always clone all properties instead of partially cloning.

I presume you will be able to clone all public properties or does the current implementation have some limitations?

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) August 29, 2024 23:10
@MikeAlhayek MikeAlhayek merged commit 09d10ec into main Aug 29, 2024
11 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/fix-merge branch August 29, 2024 23:15
@gvkries
Copy link
Contributor

gvkries commented Aug 30, 2024

The commit message doesn't make any sense. Could we please be more cautious when merging 🤭

@hishamco
Copy link
Member

That's why I'm telling you @MikeAlhayek no rush :)

@MikeAlhayek
Copy link
Member Author

@gvkries what made no sense here? What was I not cautious about?

@hishamco in this case, we needed this before releasing the next preview so people can test a working produce before we soon release 2.0.

@gvkries
Copy link
Contributor

gvkries commented Aug 30, 2024

There is no reflection usage here, that is misleading. But no offense :)

@MikeAlhayek MikeAlhayek changed the title Merge JsonSerializerOptions using reflection Correct the configuration of JsonSerializerOptions Aug 30, 2024
@MikeAlhayek
Copy link
Member Author

@gvkries I corrected the title of issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants