-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the configuration of JsonSerializerOptions #16634
Conversation
Why you are going with reflection? What about PERF?
I presume you will be able to clone all public properties or does the current implementation have some limitations? |
...rchardCore/OrchardCore.Abstractions/Extensions/DocumentJsonSerializerOptionsConfiguration.cs
Show resolved
Hide resolved
The commit message doesn't make any sense. Could we please be more cautious when merging 🤭 |
That's why I'm telling you @MikeAlhayek no rush :) |
There is no reflection usage here, that is misleading. But no offense :) |
@gvkries I corrected the title of issue. :) |
Updated:
Properly fix configuring
DocumentJsonSerializerOptions
cc: @sarahelsaig