Add ShapeFactory extensions #16715
Merged
Add ShapeFactory extensions #16715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Sep 12, 2024
src/OrchardCore/OrchardCore.DisplayManagement/ShapeFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/ShapeFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
hishamco
requested changes
Sep 13, 2024
|
Sorry I updated the branch I thought it's mine :) |
|
Please check the parameters, then we can merge |
|
@hishamco anything else here? If not please approve |
|
I will do the null checks if you don't have time |
|
Which null check? |
hishamco
reviewed
Sep 15, 2024
| /// </summary> | ||
| public static ValueTask<IShape> CreateAsync(this IShapeFactory factory, string shapeType, INamedEnumerable<object> parameters) | ||
| { | ||
| if (parameters == null || parameters == Arguments.Empty) |
hishamco
requested changes
Sep 15, 2024
|
@hishamco I added the null check |
hishamco
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following extensions:
ValueTask<IShape> CreateAsync<TModel>(this IShapeFactory factory, Action<TModel> initialize = null)ValueTask<IShape> CreateAsync<TModel>(this IShapeFactory factory, Func<TModel, ValueTask> initializeAsync)