Add AddShapeTableProvider() extension method #16723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested changes
Sep 15, 2024
| /// </summary> | ||
| /// <typeparam name="TShapeProvider">The <see cref="IShapeTableProvider"/> to be registered.</typeparam> | ||
| /// <param name="services">The <see cref="IServiceCollection"/>.</param> | ||
| public static IServiceCollection AddShapeProvider<TShapeProvider>(this IServiceCollection services) |
There was a problem hiding this comment.
Probably AddShapeTableProvider so it's clear.
There was a problem hiding this comment.
Believe it or not I'm not sure why it's called ShapeTableProvider.
There was a problem hiding this comment.
@sebastienros maybe able to provide more info on the naming. But, if you want to see an extension, it would have to be the same name as the interface
hishamco
commented
Sep 15, 2024
src/OrchardCore.Modules/OrchardCore.ContentFields/Media/Startup.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/Extensions/ShapeTableProviderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/OrchardCoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/OrchardCoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/OrchardCoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/DisplayManagement/Decriptors/DefaultShapeTableManagerTests.cs
Outdated
Show resolved
Hide resolved
hishamco
commented
Sep 15, 2024
MikeAlhayek
approved these changes
Sep 16, 2024
MikeAlhayek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.