Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #16732

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Update packages #16732

merged 3 commits into from
Sep 16, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek
Copy link
Member Author

@Piedone when I updated these packages, all these changes automatically were done. I am wondering if this is one of the reasons why the bot was failing.

also, since this update, the test had a warring which caused the build to fail. This could be another reason that caused the bot to chock.

If you are good with these changes, I like to merge and see if the bot would run next to upgrade GraphQL packages (which I did not update here)

@MikeAlhayek MikeAlhayek requested a review from Piedone September 16, 2024 21:18
@MikeAlhayek MikeAlhayek merged commit c417869 into main Sep 16, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/update-packages branch September 16, 2024 22:42
@Piedone
Copy link
Member

Piedone commented Sep 16, 2024

The bot doesn't care about the build or tests, it'll open a PR with the package updates and watch as both fail without issues. So, I don't know.

@MikeAlhayek
Copy link
Member Author

The bot ran successfully after these packages were updated.

We'll watch it next time and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants