Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ContainedPartIndex behavior for DisplayText over 255 chars long #16738

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

XopcT
Copy link
Contributor

@XopcT XopcT commented Sep 17, 2024

Hi! Currently there is an issue when adding content items with long DisplayText (over 255 chars) as a child list item. Postgres database allowes only 255 chars for ContainedPartIndex.DisplayText column. So this fix truncates long DisplayText to 255 chars, similart to ContentItemIndex behavior

Fixes #16739

Copy link
Contributor

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

If you like Orchard Core, please star our repo and join our community channels.

@XopcT
Copy link
Contributor Author

XopcT commented Sep 17, 2024

@dotnet-policy-service agree

@MikeAlhayek
Copy link
Member

@XopcT thanks for this PR. You'll need to agree to the dotnet policy. But also, you'll need to set the same length of the column here

@MikeAlhayek
Copy link
Member

adding do not merge label until after dotnet-policy is agreed, then we can merge.

@XopcT
Copy link
Contributor Author

XopcT commented Sep 18, 2024

adding do not merge label until after dotnet-policy is agreed, then we can merge.

Hi! I'm pretty to this repository. How should I agree?

@MikeAlhayek
Copy link
Member

I did not realize that you already have.

@MikeAlhayek MikeAlhayek merged commit c7b2e38 into OrchardCMS:main Sep 18, 2024
5 checks passed
Copy link
Contributor

Congratulations on your first PR merge! 🎉 Thank you for your contribution! We're looking forward to welcoming other contributions of yours in the future. @all-contributors please add @XopcT for code.

If you like Orchard Core, please star our repo and join our community channels.

Copy link
Contributor

@github-actions[bot]

I've put up a pull request to add @XopcT! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainedPartIndex fails when DisplayText over 255 chars long
2 participants