Added unit test for RedisCacheWrapper. #16787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I will do it but it's great that you picked up 😁 |
|
I will review you the PR tomorrow if not today |
Yeah, I saw that you're assigned to that issue. I was just thinking about how one may test something like this and wanted to share my approach. Feel free to close this PR, if you have a different or better way of doing it.🤗 |
hishamco
requested changes
Sep 27, 2024
src/OrchardCore.Modules/OrchardCore.Redis/OrchardCore.Redis.csproj
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.Redis/RedisCacheWrapperTests.cs
Show resolved
Hide resolved
…proj Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
reviewed
Sep 28, 2024
|
|
||
| public RedisCacheWrapper(IOptions<RedisCacheOptions> optionsAccessor) => _cache = new RedisCache(optionsAccessor); | ||
| public RedisCacheWrapper(IDistributedCache cache) => _cache = cache ?? throw new ArgumentNullException(nameof(cache)); |
There was a problem hiding this comment.
I'm not sure why you changed the parameter type?
There was a problem hiding this comment.
Because RedisCache cannot be easily mocked for unit testing.
hishamco
approved these changes
Sep 29, 2024
|
@sebastienros do you have anything else to add here? |
sebastienros
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16761
/cc @hishamco