Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix First-time Contributor Welcome workflow randomly hitting rate limits (Lombiq Technologies: OCORE-201) #16797

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix First-time Contributor Welcome workflow randomly hitting rate limits (Lombiq Technologies: OCORE-201) #16797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ac760
Fix First-time Contributor Welcome workflow randomly hitting rate limits
Piedone Sep 25, 2024
1800109
Sample for PR to issue linking
Piedone Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/first_time_contributor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
# directly.
- uses: OrchardCMS/welcome-action@task/update-to-node-20
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
FIRST_ISSUE_COMMENT: >
Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't
completed the template yet, please take a moment to do so. This ensures that we fully understand your feature
Expand Down
2 changes: 1 addition & 1 deletion src/docs/guides/contributing/contributing-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ You might also read these two blog posts on contributing code: [Open Source Cont
- Make sure the repository can be built and all tests pass. This is also checked by the CI workflows.
- If you change CSS or JavaScript files, be sure to run [the Gulp pipeline](../../guides/gulp-pipeline/README.md).
- If you want to start a conversation with other community members or run the CI workflows but you're not done yet, open your PR as a [draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests). Then, [change it to ready for review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request).
- If your PR addresses an issue, be sure to [link them](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). This helps everyone find their way around contributions, and merging your PR will automatically close the issue too.
- If your PR addresses an issue, be sure to [link them](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) (e.g. with `Fixes #IssueId`). This helps everyone find their way around contributions, and merging your PR will automatically close the issue too.
- If there's no issue for your PR, then please describe the context and rationale in the pull request description, and provide screenshots/screen recordings of the changes if they affect the UX.
- Refactoring is great, but if you do so, please guard it with new tests.
- If you add a significant new feature or a breaking change, then document this under the release notes of the upcoming release (you can find this in the `docs/OrchardCore.Docs/releases` folder).
Expand Down