Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias and slug alternates for widgets too #16848

Closed

Conversation

giannik
Copy link
Contributor

@giannik giannik commented Oct 8, 2024

allow alias and slug alternates for widgets along woth content shapes

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! When addressing review feedback, please adhere to the following:

  • Please update your pull request according to feedback until it is approved by one of the core team members.
  • Apply suggested changes directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, and that's fine.
  • Don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
  • Feel free to mark conversations that you addressed to keep track of them with an emoji or otherwise, just don't resolve them.
  • Please keep conversations happening in line comments in those convos, otherwise, communication will be a mess. If you have trouble finding them, see this video.
  • When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.

@giannik giannik requested a review from Piedone October 9, 2024 15:20
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also document it similar to https://docs.orchardcore.net/en/latest/reference/modules/Templates/#content__alias__alias and https://docs.orchardcore.net/en/latest/reference/modules/Templates/#content__slug__slug, see https://docs.orchardcore.net/en/latest/guides/contributing/contributing-documentation/. Also add a note about it to the release notes of the upcoming release (you can find this in the docs/OrchardCore.Docs/releases folder).

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

@giannik giannik requested a review from Piedone October 9, 2024 19:16
@giannik
Copy link
Contributor Author

giannik commented Oct 9, 2024

@Piedone can you check the conflict with src/docs/releases/2.1.0.md

@Piedone
Copy link
Member

Piedone commented Oct 9, 2024

What do you mean by check the conflict? Please merge from main and resolve the conflict. Otherwise, the PR looks good.

@giannik
Copy link
Contributor Author

giannik commented Oct 10, 2024

replaced by #16860

@giannik giannik closed this Oct 10, 2024
@Piedone
Copy link
Member

Piedone commented Oct 10, 2024

Please merge next time instead of opening a new PR. This adds needless friction, since I now need to review the whole PR again, not just the recent changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants