Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new app setting for key vault so we can set Vault URI #16948

Merged

Conversation

mohit-naroliya
Copy link
Contributor

We're currently generating the Vault URI in the codebase using the keyvaultname, which works for Azure Cloud. However, since Azure Gov and Azure China Cloud use different Vault URIs, it doesn't work for them. I'm adding a new appsetting configuration that will allow us to specify the Vault URI directly.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

If you like Orchard Core, please star our repo and join our community channels.

@mohit-naroliya
Copy link
Contributor Author

mohit-naroliya commented Nov 4, 2024 via email

…AzureKeyVaultConfigurationExtension.cs

Co-authored-by: Mike Alhayek <[email protected]>
…naroliya/OrchardCore into Mohit/Azure-Gov-Key-Vault

# Conflicts:
#	src/OrchardCore/OrchardCore.Configuration.KeyVault/Extensions/AzureKeyVaultConfigurationExtension.cs
@MikeAlhayek MikeAlhayek merged commit e8b37b3 into OrchardCMS:main Nov 6, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Congratulations on your first PR merge! 🎉 Thank you for your contribution! We're looking forward to welcoming other contributions of yours in the future. @all-contributors please add @mohit-naroliya for code.

If you like Orchard Core, please star our repo and join our community channels.

Copy link
Contributor

@github-actions[bot]

I've put up a pull request to add @mohit-naroliya! 🎉

@sebastienros
Copy link
Member

Thanks @mohit-naroliya. Could you also add the entry in the "mock" app settings file src\OrchardCore.Cms.Web\appsettings.json ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants