Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove module to module reference #16951

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove module to module reference #16951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@
using OrchardCore.Admin;
using OrchardCore.DisplayManagement;
using OrchardCore.DisplayManagement.Notify;
using OrchardCore.Mvc.Core.Utilities;
using OrchardCore.Navigation;
using OrchardCore.Routing;
using OrchardCore.Templates.Models;
using OrchardCore.Templates.Services;
using OrchardCore.Templates.ViewModels;
using PlacementsAdminController = OrchardCore.Placements.Controllers.AdminController;

namespace OrchardCore.Templates.Controllers;

Expand Down Expand Up @@ -389,13 +387,11 @@ private async Task ValidateModelAsync(TemplateViewModel model, TemplatesDocument

if (string.IsNullOrWhiteSpace(model.Content))
{
var placementsLink = Url.ActionLink(
nameof(PlacementsAdminController.Index),
typeof(PlacementsAdminController).ControllerName(),
new { area = "OrchardCore.Placements" });
var placementsLink = Url.ActionLink("Index", "Admin", new { area = "OrchardCore.Placements" });
var docsLink = "https://docs.orchardcore.net/en/main/reference/modules/Placements/";

await _notifier.WarningAsync(H["If you left the content empty because you want to hide the shape, use <a href=\"{0}\">Placements</a> instead. See <a href=\"{1}\">the docs</a> for more info about this feature.", placementsLink, docsLink]);

ModelState.AddModelError(nameof(TemplateViewModel.Content), S["The content is mandatory."]);
}
}
Expand Down
1 change: 0 additions & 1 deletion src/OrchardCore.Modules/OrchardCore.Templates/OrchardCore.Templates.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Navigation.Core\OrchardCore.Navigation.Core.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Recipes.Abstractions\OrchardCore.Recipes.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ResourceManagement\OrchardCore.ResourceManagement.csproj" />
<ProjectReference Include="..\OrchardCore.Placements\OrchardCore.Placements.csproj" />
</ItemGroup>

</Project>