-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssignRoleToUsers should not be implied by EditUsers #16954
Conversation
@hishamco the issue is tagged with 3.0. It is probably better to work on these issues when we are getting ready to release 3.0 to avoid conflicts and extra work |
To be honest I'm not sure what is the roadmap, I think we should make this clear to everyone on the team |
The issue is assigned to 3.0 milestones. That means it won't be merged in 2.x. |
I changed it to |
You can't change it. It's a breaking change. That's why it was tagged with 3.0. |
While it's a bug we need to fix, this is a behavior breaking-change, I remembered we avoid code breaking-changes |
its not a bug and has been like this for a long time. But we should not need that EditUsers permissions there. |
@hishamco please document this change into 3.0.0 release notes and we'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use descriptive docs in the release notes to help users understand what happened and what they should do to maintain behavior.
Fixes #16756