Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Liquid Culture accessor #16956

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Improve Liquid Culture accessor #16956

merged 11 commits into from
Nov 7, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Nov 5, 2024

Fixes #16957

@sebastienros
Copy link
Member

Working:

Culture: {{ Culture }} <br/>
Culture.Name: {{ Culture.Name }} <br/>
Culture == "en-US": {{ Culture == "en-US" }} <br/>
Culture == "en-EN": {{ Culture == "en-EN" }} <br/>
Culture.Dir: {{ Culture.Dir }} <br/>
Culture.DisplayName: {{ Culture.DisplayName }} <br/>
Culture.NativeName: {{ Culture.NativeName }} <br/>
Culture.TwoLetterISOLanguageName: {{ Culture.TwoLetterISOLanguageName }} <br/>

image

@hishamco
Copy link
Member Author

hishamco commented Nov 7, 2024

Looks good, something I might not aware about in the past I thought the Scope.SetValue sets a value for each user

@hishamco
Copy link
Member Author

hishamco commented Nov 7, 2024

Anything else or shall we merge it, coz I need to rid of the SupportedCultures filter in the next PR

@sebastienros
Copy link
Member

sets a value for each user

In this case for each tenant. If you put a breaking it should be hit once.

@sebastienros sebastienros merged commit e3cd15c into main Nov 7, 2024
7 checks passed
@sebastienros sebastienros deleted the hishamco/culture-liquid branch November 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Liquid Culture accessor
2 participants