-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Liquid Culture accessor #16956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Nov 5, 2024
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/LiquidCultureAccessor.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/CultureValue.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/CultureValue.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/CultureValue.cs
Outdated
Show resolved
Hide resolved
…ltureValue.cs Co-authored-by: Sébastien Ros <[email protected]>
sebastienros
reviewed
Nov 7, 2024
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/OrchardCoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sebastienros
reviewed
Nov 7, 2024
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/CultureValue.cs
Outdated
Show resolved
Hide resolved
Working:
|
Looks good, something I might not aware about in the past I thought the |
Anything else or shall we merge it, coz I need to rid of the SupportedCultures filter in the next PR |
In this case for each tenant. If you put a breaking it should be hit once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16957