Move CultureValue to OC.Localization module

[hishamco]

To keep things clear and consistent it would be nice to move the CultureValue into the OC.Localization module, this way the fluid value will show up once the Liquid module is enabled

[sebastienros]

I don't think we should do it. The ILocalizationService is available outside of this module, we have a default implementation. And one could use this helper in liquid to get the current culture, whatever it is, even without the localization module. And another module could implement ILocalizationService too.

[hishamco]

The ILocalizationService is available outside of this module, we have a default implementation

The default implementation inside the module

And one could use this helper in liquid to get the current culture, whatever it is, even without the localization module. And another module could implement ILocalizationService too.

I might agree if DefaultCulture and SupportedCultures was in Locale object to Culture

[sebastienros]

DefaultLocalizationService is in OrchardCore. ILocalizationService is in OrchardCore.Abstractions.

DefaultCulture and SupportedCulture are part of this service. So this object will always work even without our localization module. I confirm my recommendtaion.

[hishamco]

DefaultLocalizationService is in OrchardCore. ILocalizationService is in OrchardCore.Abstractions.

Right

No problem closing this then