Introduce FluidValue for Hosting Environment #16972
Conversation
|
|
||
| namespace OrchardCore.DisplayManagement.Liquid.Values; | ||
|
|
||
| internal sealed class HostingEnvironmentValue : FluidValue |
There was a problem hiding this comment.
What's the advantage of this implementation over the current one?
There was a problem hiding this comment.
This is simpler to understand with one less indirection. Instead of registering a marker object (the accessor) and checking any property used in Liquid for this type, we register an object directly and let it return sub-properties when it is accessed.
There was a problem hiding this comment.
I see, thanks. @hishamco please document if anything changes here: https://docs.orchardcore.net/en/latest/reference/modules/Liquid/#environment
There was a problem hiding this comment.
Nothing to be changed in the usage, no breaking-changes
|
|
||
| namespace OrchardCore.DisplayManagement.Liquid.Values; | ||
|
|
||
| internal sealed class HostingEnvironmentValue : FluidValue |
There was a problem hiding this comment.
This is simpler to understand with one less indirection. Instead of registering a marker object (the accessor) and checking any property used in Liquid for this type, we register an object directly and let it return sub-properties when it is accessed.
|
|
||
| return NilValue.Instance; | ||
| }); | ||
| o.Scope.SetValue("Environment", new HostingEnvironmentValue()); |
There was a problem hiding this comment.
Can't the value of the environment be found at that point, the same way we would use it to register specific middlewares or not. Then we can just pass it once to the FluidValue and preset the IsXZY values in it.
There was a problem hiding this comment.
I go with the current implement because I can't resolve IHostEnvironment, let me check again. Agree that resolving the value once is enough in case of the environment not like the culture
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/HostingEnvironmentValue.cs
Outdated
Show resolved
Hide resolved
…stingEnvironmentValue.cs Co-authored-by: Sébastien Ros <[email protected]>
No description provided.