Fix JSON parsing errors caused by spaces and special characters in Lu… #16981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a unit test? |
hishamco
requested changes
Nov 9, 2024
Co-authored-by: Hisham Bin Ateya <[email protected]>
Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
approved these changes
Nov 9, 2024
|
@MikeAlhayek do you have anything else to add here? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSON parsing errors caused by spaces and special characters in LuceneQuerySource
LuceneQuerySourcewhere spaces and special characters like/were causing errors.parameterizedQueryparsing logic to handle these cases correctly.As we can see from the following Lucene query, if there are liquid expressions within the template, it causes spaces in the JSON, leading to errors.