Improve functional tests #16982
Merged
Improve functional tests #16982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Nov 11, 2024
MikeAlhayek
reviewed
Nov 11, 2024
Comment on lines
+4
to
+6
| cy.get("#LoginForm_UserName").type(config.username); | ||
| cy.get("#LoginForm_Password").type(config.password); | ||
| cy.get("#LoginForm_UserName").closest('form').submit(); |
There was a problem hiding this comment.
Humm, how did this pass in the past?
There was a problem hiding this comment.
The "dist" folder was fine, it was changed manually. And the "dist" is generated. So as long as we didn't generate a new "dist" it was working. Kind of the same problem we had with the static assets, so we could add this to the validation action such that the source and generated scripts are never out of sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved documentation and fixed the generated script files.
Fail functional tests when an exception is not handled or a error is logged.