Fix Media Cache Handler #16992
Merged
Fix Media Cache Handler #16992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
approved these changes
Nov 11, 2024
|
|
||
| return Task.CompletedTask; | ||
| } | ||
| => _mediaFileStoreCacheFileProvider.TryDeleteDirectoryAsync(context.Path); |
There was a problem hiding this comment.
I think we accepted the rule to use block body for methods, ctor and conversions. Only use expression body for properties and indexers.
There was a problem hiding this comment.
I don't think there was an objection into using expression for one line like this.
There was a problem hiding this comment.
I looked at the editor config and watched the meeting. You are correct, for methods we "can" use expression bodies when it is on a single line.
Like fire and forget? If so, that would be done at the higher level not here. I don't think there is a reason to execute a task and return a completed task. Maybe I am missing something here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.