Release 2.1

[MikeAlhayek]

Fix #16995

[hishamco]

Seems you didn't see my comment 5 days ago #16995 (comment)

[MikeAlhayek]

Seems you didn't see my comment 5 days ago #16995 (comment)

I did not.

[MikeAlhayek]

@sebastienros I think next steps are as follow:

1. Release translation package on nuget.
2. Update the package from nuget instead of cloud-smith.
3. Merge main to release/2.1
4. Merge releasel/2.1 on main
5. Ship 2.1.

Do you see an issue with this?

[sebastienros]

I published the 2.1.0 translations packages.

[MikeAlhayek]

I published the 2.1.0 translations packages.

@sebastienros I updated the PR to use the 2.1.0. Let me know if you agree with the following steps next:

• Merge main to release/2.1
• Merge releasel/2.1 on main
• Ship 2.1.

[hishamco]

@MikeAlhayek please hold on to this, there's a reported issue in Po Extractor OrchardCoreContrib/OrchardCoreContrib.PoExtractor#100

@agriffard did you see such an error before, if nothing stopper we can ship OC 2.1, otherwise I will publish a patch release ASAP

[agriffard]

@MikeAlhayek please hold on to this, there's a reported issue in Po Extractor OrchardCoreContrib/OrchardCoreContrib.PoExtractor#100

@agriffard did you see such an error before, if nothing stopper we can ship OC 2.1, otherwise I will publish a patch release ASAP

I didn't have any error to update the .pot translation files.

[sebastienros]

Any PRs merged in translations looked good. Only issue could be that we missed some strings.

[MikeAlhayek]

@hishamco that issue isn't impacting us per @sebastienros and @agriffard. We'll be shipping soon.

[hishamco]

I replied to you on WhatsApp, but there's no respond from the author, so I can't reproduce the issue. Feel free to go